fix: Autocpu-freq script not detecting battery on laptops#877
fix: Autocpu-freq script not detecting battery on laptops#877ChrisTitusTech merged 2 commits intoChrisTitusTech:mainfrom
Conversation
Co-authored-by: nyx <nnyyxxxx@protonmail.com>
|
Alright, thanks for the suggestions, I have removed the comment. |
jeevithakannan2
left a comment
jeevithakannan2
left a comment
There was a problem hiding this comment.
While this solves the laptop issue. This doesn't solve the error that occurs after installation.
Add these lines after installation steps
sudo auto-cpufreq --install
that is not related to this pull request, and it should be used with $ESCALATION_TOOL not sudo |
The issue mentions two issues and this PR only resolves only one issue. And I just copy pasted the sudo auto-cpufreq --install from the err log |
again, |
Then it does not resolve that issue completely. Please re-read the issue !! |
ok? and is that my problem? why should i read the issue, once again |
|
issues and pull requests should be focused on 1 bug, or 1 implementation, they should not include multiple bugs or multiple implementations, if you want you can split your issue into 2 since that would be better |
I am getting what you're trying to say but this is not a big change. Not going to waste time on two separate PRs and issues while it can be easily fixed by adding a line in single PR and change PR title to auto cpu-freq fixes. |
please re read the message you're responding to !!, that second issue is not related to this PR at all and should not be included |
Waste of time and resources for a simple fix. |
re read the reply chain one more time !! maybe you'll understand the issue we're arguing about |
|
What in tarnation is going on here, doesn't it run the autocpu-freq --install on line 37 of the install function? |
Looks like I was hallucinating. When I took the SS that line was not called. See the SS in the issue. |
|
looks like theres an extra space separating escalation tool on that line |
Yeah but that shouldn't cause issues. I cannot reproduce the issue again. |
|
If you want I can remove the extra space... |
|
damn what happened here too heated IMO |
4 participants
Type of Change
Description
Testing
I have tested this on my Arch Linux install on DESKTOP. (no battery)
However it should work.
Impact
All this does is if there is any battery it will run the function for laptops and not desktops.
It fixes the issue of not detecting a laptop and instead runs the power profile meant for desktops.
Issues / other PRs related
Checklist